what is the hallmark of a good trading strategy?

A good trading strategy is repeatable meaning it has to be something that can be traded on a daily basis.

It also have risk management in it, meaning a stop loss & take profit target. A good strategy doesnt have to work 100% of the time, even 30% is okay.

Just ensure that when it doesnt work, you dont jump back into the market and revenge trade (accept your loss & walk away); and when it does work, you keep adding to your winning positions.

A good trading strategy is like a drug, it must be very specific and should work only under specific conditions and only on specific instruments. it shouldn't be a one size fits all kind of strategy.

A good strategy should leave nothing to chance, every detail such as timeframe, trading session, entry/exit point, etc. must be spelt out.

I think a good strategy should give you frequent setups instead of giving you setups once in a blue moon

Not at all it doesn’t have to give you setups all the time

If you have a positive expected value, then that strategy works. For example, if you have a strategy, that works just 45% times, but gives you twice the number of pips on a winner, than a losing day, then you have an edge.

I don't think much else matters in the strategy, rest is the human element (which is extremely important). Your strategy might have an edge, but there could be many emotional triggers that could still lead to net loss.

For example, your setup could be as simple as fading the Asian move during London, as long as you don't get emotional, and take your loss on a losing day, and don't trade if there is no signal, then you would get the positive EV from your system that has an edge.

Or you could push back on a loss, take trades that are then experimental, only to lose more than you were ever going to on your actual setup. Then be really scared to take the next trade when it actually shows up.

3 signs a strategy is actually good

1. Clear rules, no guesswork - If you can’t explain entry, SL, TP in 2 sentences, it’s not a strategy. It’s hope. Good = objective conditions + defined risk.

2. Risk > Reward built-in - A good strategy survives losing streaks. Minimum 1:2 RR, max 1-2% risk. If 5 losses in a row blows your account, the strategy is the problem, not the market.

3. You can execute it for 100 trades - Good strategy fits your psychology + schedule. If it stresses you, causes FOMO, or needs 24hr screen time, you’ll quit before it compounds. Consistency beats complexity.